Skip to content

Create nodejs.yml #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2020
Merged

Create nodejs.yml #8

merged 2 commits into from
Mar 18, 2020

Conversation

@StanleyMasinde
Copy link
Member

@StanleyMasinde StanleyMasinde commented Mar 17, 2020

No description provided.

@StanleyMasinde
Copy link
Member Author

StanleyMasinde commented Mar 17, 2020

@Azim254 and @billthebuilder Do you think this workflow is correct?

@conradKE
Copy link
Contributor

conradKE commented Mar 18, 2020

describe the steps to the workflow what it does

@StanleyMasinde
Copy link
Member Author

StanleyMasinde commented Mar 18, 2020

describe the steps to the workflow what it does

Please read the nodejs.yml file

billthebuilder
billthebuilder reviewed Mar 18, 2020
View reviewed changes
@StanleyMasinde
Update nodejs.yml
e7646f8 
Addition: Node version 10 test
StanleyMasinde
StanleyMasinde commented Mar 18, 2020
View reviewed changes
Copy link
Member Author

@StanleyMasinde StanleyMasinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added node 10

billthebuilder
billthebuilder approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@billthebuilder billthebuilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@StanleyMasinde StanleyMasinde merged commit cf8b8cc into master Mar 18, 2020
@StanleyMasinde StanleyMasinde deleted the stannlee-patch-1 branch March 18, 2020 08:52
conradKE
conradKE reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@conradKE conradKE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billthebuilder billthebuilder billthebuilder approved these changes

+1 more reviewer

@conradKE conradKE conradKE left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanleyMasinde @conradKE @billthebuilder